Several fixes for reference types #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow `ref.func` for global initialization expressions - Allow `nullref` as a full-fledged type, after WebAssembly/reference-types#66 - Enable reference types when exnref is used (The reference types proposal is a prerequisite of the EH proposal)
|
Ping :) (Side note: Yesterday I commented on this thread about the difference between wast and wat or something, and that comment was meant for a completely different PR in Binaryen. Not sure why I ended up commenting here. If you saw it, please ignore it.) |
sbc100
approved these changes
Jan 8, 2020
| @@ -142,7 +142,7 @@ out/test/spec/bulk-memory-operations/binary.wast:725: assert_malformed passed: | |||
| 0000024: error: expected ref.null or ref.func in passive element segment | |||
| 0000025: error: expected END opcode after element expression | |||
| out/test/spec/bulk-memory-operations/binary.wast:751: assert_malformed passed: | |||
| 0000022: error: segment elem expr type must be funcref or anyref (got i32) | |||
| 0000022: error: segment elem expr type must be reference types (got i32) | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref.funcfor global initialization expressionsnullrefas a full-fledged type, after[spec/interpreter/test] Allow nullref type externally reference-types#66
proposal is a prerequisite of the EH proposal)