Skip to content

Add Arabic translation #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

doingandlearning
Copy link

Arabic internationalisation settings for user interface for UV.

Arabic internationalisation settings for user interface for UV.
@mejackreed
Copy link
Collaborator

Thanks so much for this contribution. I wonder if its possible to provide a locale file that only updates the translatable keys? Perhaps something like this:

https://github.com/UniversalViewer/universalviewer/blob/master/src/extensions/uv-seadragon-extension/l10n/xx-XX.json

(though I'm not sure those keys are current)

@doingandlearning
Copy link
Author

doingandlearning commented Apr 16, 2018

Happy to do that but is there a list of keys that are definitively up-to-date?

@mejackreed
Copy link
Collaborator

Not that I'm aware, but that seems like something we should work on. Do you know @edsilv ?

@doingandlearning
Copy link
Author

I've used the options from en-GB as the basis for my keys - if I re-order the ar-AR to look more like the en-GB, would that be better? I'll ensure that I only include things that are currently in the en-GB.

Removed options and re-ordered the keys to match the en-GB.json.

All keys defined in en-GB mapped to AR.
@doingandlearning
Copy link
Author

@mejackreed I've done this now Jack - it is now shaped exactly as en-GB and every key defined there now has an AR equivalent.

}
},
"contentLeftPanel": {
"options": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The l10n file is just for translations. Config options go in /config/ar-AR.json

"wholeImageLowResAsJpgExplanation": "يفتح في نافذة جديدة."
}
},
"content": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing a "footerPanel": {} here

Just needs translations for contentLeftPanel
@edsilv edsilv mentioned this pull request Aug 11, 2018
1 task
@demiankatz demiankatz changed the title Create ar-AR.json Add Arabic translation Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants