-
-
Notifications
You must be signed in to change notification settings - Fork 195
Add Arabic translation #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Arabic internationalisation settings for user interface for UV.
Thanks so much for this contribution. I wonder if its possible to provide a locale file that only updates the translatable keys? Perhaps something like this: (though I'm not sure those keys are current) |
Happy to do that but is there a list of keys that are definitively up-to-date? |
Not that I'm aware, but that seems like something we should work on. Do you know @edsilv ? |
I've used the options from en-GB as the basis for my keys - if I re-order the ar-AR to look more like the en-GB, would that be better? I'll ensure that I only include things that are currently in the en-GB. |
Removed options and re-ordered the keys to match the en-GB.json. All keys defined in en-GB mapped to AR.
@mejackreed I've done this now Jack - it is now shaped exactly as en-GB and every key defined there now has an AR equivalent. |
} | ||
}, | ||
"contentLeftPanel": { | ||
"options": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The l10n file is just for translations. Config options go in /config/ar-AR.json
"wholeImageLowResAsJpgExplanation": "يفتح في نافذة جديدة." | ||
} | ||
}, | ||
"content": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're missing a "footerPanel": {}
here
Just needs translations for contentLeftPanel
Arabic internationalisation settings for user interface for UV.