Skip to content

Terms of Use Overlay Improvements #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

crhallberg
Copy link
Contributor

  • Default to requiredStatement
  • Make license a link when used
  • Break words instead of hiding longer URLs
  • Give more flexibility of overlay width

Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 6:48pm

@demiankatz
Copy link
Contributor

Thanks, @crhallberg. I like how this looks, but we might need a IIIF expert to weigh in on whether this solution is entirely acceptable. I think in many cases, the requiredStatement is going to include license information... but I think it's at least theoretically possible that the license information might be independent of the required statement. Not sure what the most appropriate behavior would be there, or how to decide what to do.

One possible approach: check if the license URI is part of the required statement. If so, use the current behavior; if not, add a "License: [linked URI]" to the end.

(Not sure if that's the best approach -- just brainstorming!)

@LanieOkorodudu
Copy link
Collaborator

Thanks, @crhallberg. I like how this looks, but we might need a IIIF expert to weigh in on whether this solution is entirely acceptable. I think in many cases, the requiredStatement is going to include license information... but I think it's at least theoretically possible that the license information might be independent of the required statement. Not sure what the most appropriate behavior would be there, or how to decide what to do.

One possible approach: check if the license URI is part of the required statement. If so, use the current behavior; if not, add a "License: [linked URI]" to the end.

(Not sure if that's the best approach -- just brainstorming!)

Yeah, I agree, it would be great to get someone with more IIIF experience to weigh in. Maybe we could share this PR in a relevant community or channel to get some feedback. I’m not an expert in this area either, so some extra eyes would definitely help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants