-
Notifications
You must be signed in to change notification settings - Fork 47
Settings cannot be loaded because of NullPointerException #951 #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Vassiliy-Kudryashov
merged 7 commits into
main
from
Vassiliy-Kudryashov/951-settings-cannot-be-loaded-because-of-nullpointerexception
Sep 19, 2022
Merged
Settings cannot be loaded because of NullPointerException #951 #952
Vassiliy-Kudryashov
merged 7 commits into
main
from
Vassiliy-Kudryashov/951-settings-cannot-be-loaded-because-of-nullpointerexception
Sep 19, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oaded-because-of-nullpointerexception
Damtev
requested changes
Sep 19, 2022
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/GenerateTestsDialogWindow.kt
Outdated
Show resolved
Hide resolved
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/GenerateTestsDialogWindow.kt
Outdated
Show resolved
Hide resolved
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/GenerateTestsDialogWindow.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/utbot/intellij/plugin/ui/components/CodeGenerationSettingItemRenderer.kt
Outdated
Show resolved
Hide resolved
After-review improvements
Damtev
requested changes
Sep 19, 2022
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/GenerateTestsDialogWindow.kt
Outdated
Show resolved
Hide resolved
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/GenerateTestsDialogWindow.kt
Outdated
Show resolved
Hide resolved
After-review improvements 2
After-review improvements 3
…oaded-because-of-nullpointerexception
Damtev
approved these changes
Sep 19, 2022
…oaded-because-of-nullpointerexception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now CodeGenerationSettingItem.toString() goes to serialization and CodeGenerationSettingItem.displayName is being used in UI renderers.
Fixes #951
Type of Change
How Has This Been Tested?
Manual Scenario
Open recently built plugin with pretty old configured project (somewhen before #753 implemenation), startup shouldn't fail (see the issue).
Checklist (remove irrelevant options):