Skip to content

Improve settings, part 1 #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 15, 2022
Merged

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Sep 9, 2022

Description

Fixes # (753)

Type of Change

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Manual Scenario

Settings appearance requires the mentioned issue, there is no regress in functionality

@Vassiliy-Kudryashov Vassiliy-Kudryashov marked this pull request as ready for review September 14, 2022 22:47
@@ -593,11 +593,11 @@ enum class RuntimeExceptionTestsBehaviour(
override val description: String
) : CodeGenerationSettingItem {
PASS(
displayName = "Passing",
displayName = "Fail",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct?

Copy link
Collaborator

@Markoutte Markoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see a comment

Fix for misprint
@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) September 15, 2022 09:09
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit b39d01a into main Sep 15, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the egor/settings_improvement branch September 15, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants