Skip to content

Required libraries can be installed silently #492 #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Vassiliy-Kudryashov
Copy link
Member

Description

Getting rid of all needless Yes/No and OK/Cancel dialogs that dramatically slowdown first time use case

Fixes #492

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual Scenario

Prepare environment with clean config (e.g. no required libraries (JUnit/Mockito etc. in dependencies, empty or absent resources folder) and run tests generation. Single OK click does everything now.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings

@Vassiliy-Kudryashov Vassiliy-Kudryashov linked an issue Jul 11, 2022 that may be closed by this pull request
@Vassiliy-Kudryashov Vassiliy-Kudryashov requested review from EgorkaKulikov and removed request for denis-fokin July 12, 2022 07:14
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make an extension class be a little more carefully implemented and clear to newcomers.
Also I have two questions not related to code quality.

@EgorkaKulikov EgorkaKulikov self-requested a review July 18, 2022 05:21
@EgorkaKulikov
Copy link
Collaborator

@alisevych I suggest to test this functionality carefully in different projects (Maven, Gradle, Idea) of different versions. Potential breaking changes.

@alisevych
Copy link
Member

@EgorkaKulikov @Vassiliy-Kudryashov
I've published plugin from this branch as archive and tested it on IDEA Ultimate 2022.1.3

During testing I faced IndexNotReadyException (see #273) almost every time I've tried to generate tests in a manually created folder in IDEA project.
It was thrown on the first UTBot test generation after IDEA restarted.
On the next calls the tests were generated to the new test root correctly.

No other issues found so far.
As @Vassiliy-Kudryashov suggested, merging latest changes from main into this branch can make sense.
So could please notify me after update? I would check some more cases.

@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) July 20, 2022 09:07
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 661a89a into main Jul 20, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/492-required-libraries-can-be-installed-silently branch July 20, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Required libraries can be installed silently
3 participants