-
Notifications
You must be signed in to change notification settings - Fork 47
Logging redesign #1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging redesign #1547
Conversation
3f72d71
to
7f97aa5
Compare
3c3a624
to
145e036
Compare
145e036
to
3b88fee
Compare
ae0546c
to
4d86647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK after fixing remarks, but I didn't dive into details deeply. I guess, you need to update docs.
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/tree/CgMethodConstructor.kt
Outdated
Show resolved
Hide resolved
...instrumentation/src/main/kotlin/org/utbot/instrumentation/process/InstrumentedProcessMain.kt
Show resolved
Hide resolved
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/ConcreteExecutor.kt
Outdated
Show resolved
Hide resolved
4d86647
to
5eac028
Compare
9eb68e0
to
c54dc3b
Compare
@Domonion Please add logging of Summarization phase: started - ended. |
b8ae7bb
to
2892c2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGNP2m
utbot-maven/src/main/kotlin/org/utbot/maven/plugin/GenerateTestsAndSarifReportMojo.kt
Show resolved
Hide resolved
utbot-rd/src/main/kotlin/org/utbot/rd/loggers/UtRdRemoteLogger.kt
Outdated
Show resolved
Hide resolved
utbot-summary/src/main/kotlin/org/utbot/summary/Summarization.kt
Outdated
Show resolved
Hide resolved
b2b4df5
to
c96c830
Compare
Complete logs redesign: 1. Added Logger model to rd. 2. InstrumentedProcess is now sending all logs to EngineProcess, which then writes to its own file. 3. Removed UtSettings.instrumentedProcessLogLevel 4. Auxiliary log functions 5. UtRdLoggers redesigned to have the same logging pattern 6. From now log4j2.xml is responsible for instrumentation process log configuration 7. Added summarization start/end log notifications and instrumented process starting messages. 8. Design doc for logs, clarifying comments and refactoring. 9. Changed `bracket` to `logMeasure`. its signature from plain string message to lambda to remove extra interpolation when message log level is not supported/
c96c830
to
719262f
Compare
Description
Fixes #1122
Type of Change