Skip to content

Logging redesign #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Logging redesign #1547

merged 1 commit into from
Feb 8, 2023

Conversation

Domonion
Copy link
Collaborator

@Domonion Domonion commented Dec 16, 2022

Description

  1. Added Logger model to rd
  2. InstrumentedProcess is now sending all logs to EngineProcess, which then writes to its own file
  3. Removed instrumentedProcessLogLevel
  4. auxiliary log functions
  5. stop process rdcall
  6. UtRd Loggers redesigned to have the same logging pattern

Fixes #1122

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (typos and non-functional changes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Domonion Domonion force-pushed the kononov-logs branch 2 times, most recently from 3f72d71 to 7f97aa5 Compare December 16, 2022 14:15
@Domonion Domonion marked this pull request as draft December 16, 2022 14:32
@Domonion Domonion force-pushed the kononov-logs branch 2 times, most recently from 3c3a624 to 145e036 Compare December 16, 2022 14:41
@Domonion Domonion changed the title Utbot logging Logging redesign Dec 16, 2022
@Domonion Domonion force-pushed the kononov-logs branch 2 times, most recently from ae0546c to 4d86647 Compare January 26, 2023 13:02
@Domonion Domonion marked this pull request as ready for review January 26, 2023 13:03
Copy link
Member

@sergeypospelov sergeypospelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK after fixing remarks, but I didn't dive into details deeply. I guess, you need to update docs.

@Domonion Domonion closed this Jan 27, 2023
@Domonion Domonion reopened this Jan 27, 2023
@Domonion Domonion enabled auto-merge (squash) January 27, 2023 16:20
@Domonion Domonion self-assigned this Jan 27, 2023
@Domonion Domonion added the comp-logging Issue is related to Logging label Jan 27, 2023
@Domonion Domonion disabled auto-merge January 30, 2023 12:50
@alisevych
Copy link
Member

@Domonion Please add logging of Summarization phase: started - ended.

Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGNP2m

@Domonion Domonion enabled auto-merge (squash) February 8, 2023 13:55
Complete logs redesign:
1. Added Logger model to rd.
2. InstrumentedProcess is now sending all logs to EngineProcess, which then writes to its own file.
3. Removed UtSettings.instrumentedProcessLogLevel
4. Auxiliary log functions
5. UtRdLoggers redesigned to have the same logging pattern
6. From now log4j2.xml is responsible for instrumentation process log configuration
7. Added summarization start/end log notifications and instrumented process starting messages.
8. Design doc for logs, clarifying comments and refactoring.
9. Changed `bracket` to `logMeasure`. its signature from plain string message to lambda to remove extra interpolation when message log level is not supported/
@Domonion Domonion merged commit 1e5b593 into main Feb 8, 2023
@Domonion Domonion deleted the kononov-logs branch February 8, 2023 14:32
@alisevych alisevych added the ctg-enhancement New feature, improvement or change request label Feb 9, 2023
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-logging Issue is related to Logging ctg-enhancement New feature, improvement or change request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Testability: add log records on test generation phases
4 participants