Skip to content

[wip] passing node-notifier options #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Gvozd
Copy link
Collaborator

@Gvozd Gvozd commented Dec 11, 2020

  • testing direct passing otpions
  • document it
  • support custom sub-options like
new WebpackNotifierPlugin ({
  notifier: 'NotificationCenter',// or constructor - require('node-notifier').NotificationCenter
  notifierOptions: {
    withFallback: false,
    customPath: undefined
  },
  notifyOptions: {
    appID: 'com.squirrel.your.app'
  }
});

@Gvozd Gvozd changed the title passing node-notifier options [wip] passing node-notifier options Dec 11, 2020
@Nothing-Works
Copy link

Nothing-Works commented Dec 11, 2020

@Gvozd maybe just one little thing, I think you should consider user appID as the key rather than appId as appID is matching the exact key from node-notifier. see here

@Gvozd
Copy link
Collaborator Author

Gvozd commented Dec 11, 2020

@Nothing-Works Yes, I sealed
of course the appID is correct

corrected the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants