Skip to content

ci(*): init ESLint configurations to include 'vitest/expect-expect' rule as error across multiple packages gradually #9104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 6, 2025
Merged

ci(*): init ESLint configurations to include 'vitest/expect-expect' rule as error across multiple packages gradually #9104

merged 7 commits into from
May 6, 2025

Conversation

manudeli
Copy link
Collaborator

@manudeli manudeli commented May 5, 2025

No description provided.

@manudeli
chore(*): init ESLint configurations to include 'vitest/expect-expect…
8f4c6cf 
…' rule as error across multiple packages gradually
@manudeli manudeli changed the title chore(*): init ESLint configurations to include 'vitest/expect-expect' rule as error across multiple packages gradually ci(*): init ESLint configurations to include 'vitest/expect-expect' rule as error across multiple packages gradually May 5, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 7018138.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 47s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 08:13:58 UTC

manudeli
manudeli commented May 5, 2025
View reviewed changes
eslint.config.js
Comment on lines -48 to -51
rules: {
...vitest.configs.recommended.rules,
'vitest/expect-expect': 'warn',
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initiate eslint vitest/expect-expect as error for all package

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 5, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9104

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9104

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9104

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9104

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9104

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9104

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9104

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9104

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9104

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9104

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9104

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9104

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9104

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9104

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9104

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9104

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9104

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9104

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9104

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9104

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9104

commit: 7018138

@codecov Codecov
Copy link

codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.50%. Comparing base (127bd01) to head (7018138).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9104   +/-   ##
=======================================
  Coverage   44.50%   44.50%           
=======================================
  Files         204      204           
  Lines        8150     8150           
  Branches     1819     1827    +8     
=======================================
  Hits         3627     3627           
  Misses       4080     4080           
  Partials      443      443
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.04% <ø> (ø)
@tanstack/eslint-plugin-query 83.02% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 95.96% <ø> (ø)
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manudeli manudeli marked this pull request as ready for review May 6, 2025 08:11
@manudeli manudeli merged commit 0943575 into TanStack:main May 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-experimental package: eslint-plugin-query package: query-async-storage-persister package: query-broadcast-client-experimental package: query-codemods package: query-core package: query-persist-client-core package: query-sync-storage-persister package: react-query package: react-query-devtools package: react-query-next-experimental package: react-query-persist-client package: solid-query package: solid-query-devtools package: solid-query-persist-client package: svelte-query package: svelte-query-devtools package: svelte-query-persist-client package: vue-query package: vue-query-devtools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manudeli