test(query-core): add test case for infiniteQueryBehavior #9101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit f0e7fad.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9101 +/- ##
===========================================
+ Coverage 44.50% 58.84% +14.34%
===========================================
Files 204 139 -65
Lines 8148 5402 -2746
Branches 1817 1438 -379
===========================================
- Hits 3626 3179 -447
+ Misses 4079 1923 -2156
+ Partials 443 300 -143 🚀 New features to boost your workflow:
|
manudeli
reviewed
May 5, 2025
Comment on lines
+446
to
+465
| const key = queryKey() | ||
|
|
||
| const queryFnSpy = vi.fn().mockImplementation(({ pageParam }) => { | ||
| return pageParam | ||
| }) | ||
|
|
||
| const observer = new InfiniteQueryObserver<number>(queryClient, { | ||
| queryKey: key, | ||
| queryFn: queryFnSpy, | ||
| getNextPageParam: (lastPage) => (lastPage === 1 ? null : lastPage + 1), | ||
| initialPageParam: 1, | ||
| }) | ||
|
|
||
| let observerResult: | ||
| | InfiniteQueryObserverResult<unknown, unknown> | ||
| | undefined | ||
|
|
||
| const unsubscribe = observer.subscribe((result) => { | ||
| observerResult = result | ||
| }) |
There was a problem hiding this comment.
In my opinion, this test don't need mocked function
Suggested change
| const key = queryKey() | |
| const queryFnSpy = vi.fn().mockImplementation(({ pageParam }) => { | |
| return pageParam | |
| }) | |
| const observer = new InfiniteQueryObserver<number>(queryClient, { | |
| queryKey: key, | |
| queryFn: queryFnSpy, | |
| getNextPageParam: (lastPage) => (lastPage === 1 ? null : lastPage + 1), | |
| initialPageParam: 1, | |
| }) | |
| let observerResult: | |
| | InfiniteQueryObserverResult<unknown, unknown> | |
| | undefined | |
| const unsubscribe = observer.subscribe((result) => { | |
| observerResult = result | |
| }) | |
| const key = queryKey() | |
| const observer = new InfiniteQueryObserver(queryClient, { | |
| queryKey: key, | |
| queryFn: ({ pageParam }) => sleep(0).then(() => pageParam), | |
| getNextPageParam: (lastPage) => (lastPage === 1 ? null : lastPage + 1), | |
| initialPageParam: 1, | |
| }) | |
| let observerResult: | |
| | InfiniteQueryObserverResult<InfiniteData<number, unknown>, Error> | |
| | undefined | |
| const unsubscribe = observer.subscribe((result) => { | |
| observerResult = result | |
| }) |
| @@ -441,4 +441,71 @@ describe('InfiniteQueryBehavior', () => { | |||
|
|
|||
| unsubscribe() | |||
| }) | |||
|
|
|||
| test('InfiniteQueryBehavior should handle null page parameters correctly', async () => { | |||
There was a problem hiding this comment.
The test name InfiniteQueryBehavior should handle null page parameters correctly is a bit vague. Consider specifying what “correctly” means in this context
manudeli
reviewed
May 5, 2025
Comment on lines
+487
to
+489
| const queryFnSpy = vi.fn().mockImplementation(({ pageParam }) => { | ||
| return pageParam | ||
| }) |
There was a problem hiding this comment.
This function don't have to be mocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved test coverage of
infiniteQueryBehaviorfrom 94.54% to 100%Before
After