Skip to content

chore: add @typescript-eslint/require-await for notice error and remove unnecessary async #9011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

chore: add @typescript-eslint/require-await for notice error and remove unnecessary async #9011

wants to merge 6 commits into from

Conversation

minseong0324
Copy link
Contributor

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 13, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit cf3e774.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 40s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-14 02:15:05 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 13, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9011

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9011

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9011

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9011

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9011

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9011

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9011

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9011

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9011

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9011

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9011

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9011

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9011

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9011

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9011

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9011

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9011

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9011

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9011

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9011

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9011

commit: cf3e774

@minseong0324 minseong0324 force-pushed the chore/async-lint-rules branch from 3ca7212 to d6fb2d3 Compare April 13, 2025 19:16
@minseong0324 minseong0324 force-pushed the chore/async-lint-rules branch from d6fb2d3 to 36542e9 Compare April 13, 2025 19:17
@minseong0324 minseong0324 changed the title chore: add @typescript-eslint/require-await for notice error chore: add @typescript-eslint/require-await for notice error and remove unnecessary async Apr 13, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.86%. Comparing base (5d12a32) to head (cf3e774).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9011       +/-   ##
===========================================
+ Coverage   44.47%   58.86%   +14.39%     
===========================================
  Files         203      138       -65     
  Lines        8104     5358     -2746     
  Branches     1804     1425      -379     
===========================================
- Hits         3604     3154      -450     
+ Misses       4066     1913     -2153     
+ Partials      434      291      -143
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.23% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 95.47% <ø> (ø)
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 14, 2025

since we want this rule everywhere, please enable it in root.eslint.config.js

@TkDodo TkDodo closed this Apr 14, 2025
@minseong0324
Copy link
Contributor Author

@TkDodo If you're referring to the whole query monorepo, would it be okay to proceed with a single PR that removes the unnecessary async keyword and adds the corresponding lint rule? I was thinking that combining them might help reduce the overhead from having to split and manage multiple PRs for related changes.

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 15, 2025

@minseong0324 yes, you can add multiple PRs that will work towards that eslint rule, but please only one PR at the very end that enables the eslint rule in the root config. I don’t want this setting set to true in multiple eslint configs.

The eslint configs in each package are only meant for really package specific overrides. For example, the react lint rules only make sense in react lated packages. But something that we want everywhere should be enabled in the root config.

This was referenced Apr 15, 2025
Open
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core package: query-devtools package: query-persist-client-core package: query-sync-storage-persister package: react-query-devtools package: react-query-persist-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minseong0324 @TkDodo