Skip to content

chore(timeout): parameterize pollTimeout #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

contacthari21
Copy link

Fixes Issue #216

Harish Narayana and others added 2 commits October 27, 2022 12:53
@Crim
Copy link
Collaborator

Crim commented Oct 27, 2022

Is there a way to pass this value thru from the UI when defining a cluster or topic?

@contacthari21
Copy link
Author

Isn't this more related to Consumer configuration and not specific to a cluster/topic configuration?

@Crim
Copy link
Collaborator

Crim commented Oct 27, 2022

Isn't this more related to Consumer configuration and not specific to a cluster/topic configuration?

I think you're correct, but there still needs to be some way to allow a user to define what that value should be, either via a config property, or via the UI (presumably tied to the cluster definition?, but maybe somewhere else, unsure)

@contacthari21
Copy link
Author

contacthari21 commented Oct 28, 2022

I think you're correct, but there still needs to be some way to allow a user to define what that value should be, either via a config property, or via the UI (presumably tied to the cluster definition?, but maybe somewhere else, unsure)

Ya, passing this value from UI would be another issue to be worked on if I think off. But what I could do is update the View table with getter and setters for pollTimeout and then have it passed as part of WebKafkaConsumerFactory's createClientConfig in this block below which will take care of the API part .. Does it sound fine ?
// Build the client config.
final ClientConfig.Builder clientConfigBuilder = ClientConfig.newBuilder()
.withTopicConfig(topicConfig)
.withConsumerId(consumerId)
.withPartitions(view.getPartitionsAsSet())
.withMaxResultsPerPartition(view.getResultsPerPartition());

I see that WebKafkaConsumerFactory creates the web consumer client by getting the values from View.

@Crim Crim merged commit 960194f into SourceLabOrg:master Oct 28, 2022
@contacthari21
Copy link
Author

@Crim Should I update the View table and the Factory and open a PR. I am unable to start up the docker image on localhost in my local, will you be able to run through it after I send in this PR to make sure it is working BAU?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants