-
Notifications
You must be signed in to change notification settings - Fork 9
Support Wasm API #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support Wasm API #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adampetro
commented
May 8, 2025
andrewhassan
reviewed
May 8, 2025
saulecabrera
reviewed
May 9, 2025
shopify_function/README.md
Outdated
```rust | ||
#[typegen("./schema.graphql")] | ||
pub mod schema { | ||
#[query("./input.graphlq")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
#[query("./input.graphlq")] | |
#[query("./input.graphql")] |
saulecabrera
approved these changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks for iterating on this. I'll leave the final approval to Andrew, since I believe there are still a couple of open items.
andrewhassan
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the chaos of the commit history. I will squash this down before merging.
At a high level, this does the following:
generate_types
andshopify_function_target
macrostypegen
macro as well as aDeserialize
derive macro for derivingshopify_function_wasm_api::Deserialize
for configuration metafield structsshopify_function
macro to behave more similarly to howshopify_function_target
previously did, in terms of adding a separate export function instead of usingmain
.I am probably missing some documentation updates and exhaustiveness of tests, and I will continue to audit that, but thought I would open it up for an initial review.
The integration tests will fail until we have a
8.0.0
release offunction-runner
that supports the Wasm API.