Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

refactor: use pname for joining throughout the application #610

Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jun 11, 2022

Closes #600.

Summary of Changes

  • Rename pname property to id
  • Use id throughout the application to join data together.

@lars-reimann lars-reimann linked an issue Jun 11, 2022 that may be closed by this pull request
11 tasks
@github-actions
Copy link

github-actions bot commented Jun 11, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.87s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 12 0 0 19.64s
✅ JSON jsonlint 12 0 9.61s
✅ JSON prettier 12 0 0 12.84s
✅ JSON v8r 12 0 8.45s
✅ PYTHON bandit 13 0 0.7s
✅ PYTHON black 13 0 0 1.06s
✅ PYTHON flake8 13 0 0.91s
✅ PYTHON isort 13 0 0 0.21s
✅ PYTHON mypy 13 0 12.32s
✅ PYTHON pylint 13 0 6.11s
✅ TSX eslint 28 0 0 14.58s
✅ TYPESCRIPT eslint 41 0 0 12.58s
✅ TYPESCRIPT prettier 69 0 0 5.48s
✅ YAML prettier 1 0 0 0.64s
✅ YAML v8r 1 0 0.56s
✅ YAML yamllint 1 0 0.13s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lars-reimann lars-reimann force-pushed the 600-use-pname-for-joining-throughout-the-application branch from fe08d4e to b62a70e Compare June 12, 2022 17:01
@lars-reimann lars-reimann marked this pull request as ready for review June 12, 2022 17:16
@lars-reimann lars-reimann merged commit 45d0224 into main Jun 12, 2022
@lars-reimann lars-reimann deleted the 600-use-pname-for-joining-throughout-the-application branch June 12, 2022 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pname for joining throughout the application
1 participant