Skip to content

[matmul code] the compiled_for_gpu crates always rebuild #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flying-sheep opened this issue Mar 27, 2025 · 0 comments · Fixed by #80
Closed

[matmul code] the compiled_for_gpu crates always rebuild #79

flying-sheep opened this issue Mar 27, 2025 · 0 comments · Fixed by #80

Comments

@flying-sheep
Copy link

When running cargo run or cargo run --release without changes on my system, the compiled_for_gpu crates always rebuild:

   Compiling compiled_isomorphic v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/isomorphic)
   Compiling compiled_workgroup_2d v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/workgroup_2d)
   Compiling compiled_tiling_1d_loop v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/tiling_1d_loop)
   Compiling compiled_tiling_2d v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/tiling_2d)
   Compiling compiled_workgroup_256 v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/workgroup_256)
   Compiling compiled_tiling_1d v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/tiling_1d)
   Compiling compiled_naive v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/naive)
    Building [======================>  ] 257/273: compiled_tiling_1d(build), compiled_workgroup_256(build), compiled_naive(build), compiled_tiling_1d_loop(build), compiled_isomorphic(build), compiled_tiling_2d(build), compiled_workgroup_2d(build)

One thing I noticed is that the build scripts println!("Generated shader binary constant…. All others I’ve seen only println!("cargo::… for build variables.

Probably meaningless, I just thought I’d mention it.
@flying-sheep flying-sheep mentioned this issue Mar 27, 2025
Closed
LegNeato added a commit to LegNeato/rust-gpu.github.io that referenced this issue Mar 29, 2025
@LegNeato
Specify when to rebuild.
3e76cec 
Sort of fixes Rust-GPU#79.

This will do a quick rebuild once and than not rebuild. It does this because
of the way I set it up for the blog post to make it extra clear what runs where.
LegNeato added a commit to LegNeato/rust-gpu.github.io that referenced this issue Mar 29, 2025
@LegNeato
Specify when to rebuild.
19b60a2 
Sort of fixes Rust-GPU#79.

This will do a quick rebuild once and than not rebuild. It does this because
of the way I set it up for the blog post to make it extra clear what runs where.
@LegNeato LegNeato mentioned this issue Mar 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mostly fix rebuilds LegNeato/rust-gpu.github.io
1 participant
@flying-sheep