Skip to content

3.x: Improve wording of operators #6843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2020
Merged

3.x: Improve wording of operators #6843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/io/reactivex/rxjava3/core/Completable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,7 +1596,7 @@ public final Completable doOnEvent(@NonNull Consumer<@Nullable ? super Throwable
* </dl>
* @param onSubscribe the consumer called when a {@link CompletableObserver} subscribes.
* @param onError the consumer called when this emits an {@code onError} event
* @param onComplete the runnable called just before when the upstream {@code Completable} completes normally
* @param onComplete the runnable called just before when the current {@code Completable} completes normally
* @param onAfterTerminate the runnable called after this {@code Completable} completes normally
* @param onDispose the {@link Runnable} called when the downstream disposes the subscription
* @return the new {@code Completable} instance
Expand Down Expand Up @@ -1834,7 +1834,7 @@ public final Completable doFinally(@NonNull Action onFinally) {
* <p>
* Note also that it is not possible to stop the subscription phase in {@code lift()} as the {@code apply()} method
* requires a non-{@code null} {@code CompletableObserver} instance to be returned, which is then unconditionally subscribed to
* the upstream {@code Completable}. For example, if the operator decided there is no reason to subscribe to the
* the current {@code Completable}. For example, if the operator decided there is no reason to subscribe to the
* upstream source because of some optimization possibility or a failure to prepare the operator, it still has to
* return a {@code CompletableObserver} that should immediately dispose the upstream's {@link Disposable} in its
* {@code onSubscribe} method. Again, using a {@code CompletableTransformer} and extending the {@code Completable} is
Expand Down Expand Up @@ -2692,7 +2692,7 @@ public final <T> Flowable<T> toFlowable() {
*
* @param <T> the value type
* @return a {@code Maybe} that only calls {@code onComplete} or {@code onError}, based on which one is
* called by the source {@code Completable}.
* called by the current {@code Completable}.
*/
@CheckReturnValue
@SuppressWarnings("unchecked")
Expand Down
Loading