Hopefully fixed missing notifications if part of the subscription is del... #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #594 SUCCESS |
|
Added test case to illustrate the underlying issue. If I comment out the new mutating part, it will fail typically with values (3, 7, 8, 9) != (3, 4, 5, 6, 7, 8, 9) |
|
RxJava-pull-requests #595 SUCCESS |
|
I'll have to spend more time on this one later to think through. |
|
Okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ayed.
Fix suggestion to issue #658.
Basically it is a "spin-lock" between onNext and the subscription. It has the additional effect of locking out concurrent subscriptions, but these would most likely clash on the state-swap anyway.