Moving unit tests to test source folders #439 #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #385 FAILURE |
|
That is an impressive amount of work @pasviegas and changes look mostly clean. I have to say, this reminds me why I prefer not having tests separated... Not thrilled with some of the privates being made package public, especially on ones where it breaks the singleton contract. I'm looking at those right now so I can try and merge without sacrificing those before anything else in the codebase changes and causes conflicts as this is a nasty thing to merge with conflicts. |
|
I have merged these changes. Thank you! |
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…nd d… (ReactiveX#465) * Reactor and RxJava RateLimiter operator try to reserve a permission and delay the subscription if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.