Skip to content

Moved state from Observable to Observer #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2013

Conversation

mairbek
Copy link
Contributor

@mairbek mairbek commented Apr 23, 2013

No description provided.

mairbek added 3 commits April 14, 2013 21:53
Conflicts:
	rxjava-core/src/main/java/rx/operators/OperatorGroupBy.java
Conflicts:
	rxjava-core/src/main/java/rx/operators/OperatorGroupBy.java
@cloudbees-pull-request-builder

RxJava-pull-requests #105 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

Is this fixing the ability to subscribe more than once?

@benjchristensen
Copy link
Member

Could you add unit tests that validate these fixes so we don't accidentally re-add the bug you're fixing in the future?

benjchristensen added a commit that referenced this pull request May 1, 2013
Moved state from Observable to Observer
@benjchristensen benjchristensen merged commit f2c53cc into ReactiveX:master May 1, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
Moved state from Observable to Observer
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…successes when using Mono/Flux.toFuture()

Circuit breaker on Mono will count success onNext or onComplete.
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…actor-mono-tofuture-success

ReactiveX#245 Fix CircuitBreakerSubscriber for Reactor doesn't count successes…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants