Improve several error codes so attribute access of names is recognised #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested changes
Jan 29, 2022
Sure |
AlexWaygood
added a commit
to AlexWaygood/typeshed
that referenced
this pull request
Jan 29, 2022
Flagged by PyCQA/flake8-pyi#161
|
typeshed PR here: python/typeshed#7079 |
Done :) |
JelleZijlstra
pushed a commit
to python/typeshed
that referenced
this pull request
Jan 29, 2022
Flagged by PyCQA/flake8-pyi#161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several error codes had issues due to the fact that the plugin hardcoded names such as
LiteralorUnioninto the logic, but did not consider that a user might access these names via attribute access, e.g.typing_extensions.Literalortyping.Union. For example, the plugin recognisedX: TypeAlias = intas a valid type alias, but did not recogniseX: typing.TypeAlias = intas a valid type alias. It's not standard "typeshed style" to access names in that way, but it's nonetheless valid, so we should probably account for that possibility.This PR fixes these bugs.