-
Notifications
You must be signed in to change notification settings - Fork 45
Display nearby books in Explore Nearby Screen #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, I would like to try solve this issue! |
Cool @kshitij5, and make sure to follow linting and the README guidelines. |
@ankitoscar you can help out @kshitij5 if required. |
@Mohitmadhav yes, I might need help! As of now, what I am doing is fetching all the other user's details, calculating their distances from the current user, and displaying books listed by them as per the requirement! But, I think this will to too costly and not scalable also! So, is there any way to reduce the reads, or is it okay for now? |
We just need the users within 10 km radius |
Hi, @Mohitmadhav. I tried implementing this feature but I just now figured out that redundant data is also getting added, every time the screen changes! I tried with Set but that doesn't seem to work. Is there any workaround? |
What redundant data exactly? |
For now I also can think of only that way which you did, one way to improve the algorithm is to store which city the user is in addition to its location, this can be helpful as we then only have to calculate distance of those in same city, we can also customise it to add blocks/sector in cities. |
The Geolocation package/api gives a detailed address based on location, so if we can store all the different values like city/state/pin number/street in user in different fields then we can do a better search, we can start with Pin Number, which is generally associated with nearest post office to limit the calculations. I hope what I am saying is understandable |
Fixes #94 : Display nearby books in Explore Nearby Screen Implemented And removed play store navigations
Uh oh!
There was an error while loading. Please reload this page.
Description
Screenshots
Steps to Reproduce
Please provide detailed steps for reproducing the issue.
Additional data
If there's something related to ML, then you can always discuss it with @ankitoscar here.
Share relevant app screenshots of your before committing any changes.
The text was updated successfully, but these errors were encountered: