Code Refactoring

[ankitoscar]

Welcome aboard, contributors 🔥 :
Here you can discuss various ways in which we can make our code more modular and the places where we can do it.
While discussing your ideas, please mention me (@ankitoscar) or Mohit (@Mohitmadhav), so that we can reach out to you ASAP.

It'll include things like:

• Improved State Management
• Code Optimization
• Reduce App size
• Project Structuring (Removing or modifying files or folders), etc

[Mohitmadhav]

@keyurgit45 for the time being you can create a separate branch and try to execute null safety.
I'll assign it to you if I don't get further updates from the assignee.

Till then, lemme check for further bugs and issues.

[keyurgit45]

@Mohitmadhav and @keyurgit45 Since the quotes package does not support null safety yet, it could be replaced entirely by using this api (http://quotes.rest/) directly. That is the api being used in the quotes package.

I am still searching for a fix or alternative for the geocoder package

Great!!

[Mohitmadhav]

@Phantom0001 you can also discuss here

[Mohitmadhav]

Till then @keyurgit45 you can take up other issues by tonight or tomorrow

[keyurgit45]

Till then @keyurgit45 you can take up other issues by tonight or tomorrow

OK... I can't give that much time coz my exams are starting. But I Will try

[Mohitmadhav]

No problem, focus on your exams then. I notified you since you asked.
Best of Luck !!

[Phantom0001]

So what is out of date? You want me to pull the main branch and check conflicts and re push?

…

On Fri, Oct 8, 2021 at 10:45 AM Mohit_007 ***@***.***> wrote: Till then @keyurgit45 <https://github.com/keyurgit45> you can take up other issues by tonight or tomorrow — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#91 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP673TMBLOVHB2FYCO6WTFDUF4G2DANCNFSM5FGGADVQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Mohitmadhav]

Yes @Phantom0001, I recently merged some PRs and made changes in upstream main.
Many things in your files were outdated with the main upstream branch

[Mohitmadhav]

So @Phantom0001 you can replace latlong with https://pub.dev/packages/latlong2. as @keyurgit45 said.
Actually, @HARSHBHUDOLIA and I used this before but got some conflicts at that time, don't remember exactly what were those.

[Mohitmadhav]

@aryang117 see if we can replace geocoder with some other package as we replaced latlong with latlong2 for null safety

[Mohitmadhav]

No problem, any free API will work for now

[aryang117]

Cool, so after making the changes, you can take up #95

Since the geocoder issue will be resolved in the null safety fix, should I just make a PR (for #132 ) with just the flutter_test fix?

[Mohitmadhav]

Sure @aryang117

[keyurgit45]

@Mohitmadhav I have made the changes for null safety migration. Should I make PR or wait till @aryang117 pushes flutter_test fix?

[Mohitmadhav]

Yeah @keyurgit45

[Mohitmadhav]

https://pub.dev/packages/googleapis