Terminal fixes #182
Merged
Terminal fixes #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingbing8
approved these changes
Jul 6, 2017
| void | ||
| ProcessIncomingKeys(char * ansikey) | ||
| { | ||
| wchar_t *buf = utf8_to_utf16(ansikey); | ||
|
|
||
| int buf_len = 0; |
There was a problem hiding this comment.
can you declare those variables before calling utf8_to_utf16, so the check on return can be right after the call?
…e UNIX SSH Server
|
|
||
| dwAttributes |= (ENABLE_ECHO_INPUT | ENABLE_LINE_INPUT | ENABLE_PROCESSED_INPUT); | ||
|
|
||
| if (!SetConsoleMode(GetStdHandle(STD_INPUT_HANDLE), dwAttributes)) |
There was a problem hiding this comment.
Why do we need this?
If console attributes are changed, they need to be reset to their original once done.
Quick fix would be to save the original attributes and revert after ReadLine returns.
manojampalam
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminal code cleanup and control sequence handling..
Terminal fixes Win32-OpenSSH#799
Picking the user32/kernel32 from the systemdirectory.
Picking the user32/kernel32 from the systemdirectory Win32-OpenSSH#814
Console settings are not restored properly
console settings are not restored properly Win32-OpenSSH#813
Fix the clearscreen issue while connecting to non-windows (UNIX/LINUX) servers.
Clearscreen issue while connecting to unix ssh server Win32-OpenSSH#807
vi arrow keys are not working
vi arrow keys are not working while connected to unix ssh server Win32-OpenSSH#806
Fix the nopty unix ssh session.
ssh -T is not working when connected to unix ssh server Win32-OpenSSH#805
Fix emacs issue
emacs terminal problem Win32-OpenSSH#802