Fixes #1628 ~ Fix types/jasmine to 2.5.45 #1640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix E2E tests currently do not compile out of the box #1628
What is the current behavior? (You can also link to an open issue here)
npm run test fail with error
ERROR in [at-loader] src/app/app.e2e.ts:12:29
TS2345: Argument of type 'string' is not assignable to parameter of type 'Expected<Promise>'.
What is the new behavior (if this is a feature change)?
Fixing the typing version fix the build
Other information:
Fixing the typing version seems to be a good practice since it can break the build at any moment