Skip to content

Add setRootView implementation #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Add setRootView implementation #84

merged 3 commits into from
Apr 23, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Apr 23, 2024

Close #81

@Kyle-Ye Kyle-Ye force-pushed the bugfix/setRootView branch from e3598c3 to 437bf77 Compare April 23, 2024 18:16
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 14.89%. Comparing base (4318efe) to head (437bf77).
Report is 1 commits behind head on main.

❗ Current head 437bf77 differs from pull request most recent head eb51cb5. Consider uploading reports for the commit eb51cb5 to get more accurate results

Files Patch % Lines
...urces/OpenSwiftUI/Core/View/ViewRendererHost.swift 0.00% 37 Missing ⚠️
Sources/OpenSwiftUI/Core/Update/Update.swift 0.00% 14 Missing ⚠️
Sources/OpenSwiftUI/Core/View/ViewGraph.swift 0.00% 6 Missing ⚠️
...rces/OpenSwiftUI/Core/View/ViewGraphDelegate.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   14.98%   14.89%   -0.10%     
==========================================
  Files         188      189       +1     
  Lines        4604     4633      +29     
==========================================
  Hits          690      690              
- Misses       3914     3943      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye force-pushed the bugfix/setRootView branch from 3ac6a7b to eb51cb5 Compare April 23, 2024 18:23
@Kyle-Ye Kyle-Ye merged commit f5d0b68 into main Apr 23, 2024
5 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/setRootView branch April 23, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BodyAccessor crash for non empty View instance
2 participants