-
Notifications
You must be signed in to change notification settings - Fork 443
fix all compile warnings #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix all compile warnings #1318
Conversation
…o other project can dependent the submodules
…on of object XXXX
…eliminated by erasure
…s after a variable pattern cannot match
@@ -488,8 +488,6 @@ class Boot extends MdcLoggable { | |||
|
|||
Migration.database.executeScripts() | |||
|
|||
Glossary.glossaryItems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line do nothing, will cause a warning.
|
||
trait ObpActorHelper { | ||
|
||
def extractResult[T](in: T) = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally wrong use of generic and match case, cause warnings.
@@ -20,38 +21,20 @@ trait ObpActorInit extends MdcLoggable{ | |||
val TIMEOUT = (ACTOR_TIMEOUT seconds) | |||
implicit val timeout = Timeout(ACTOR_TIMEOUT * (1000 milliseconds)) | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally wrong use of generic and match case, and asInstanceOf.
so just remove it, and original caller switch to call extractFutureToBox method
Hi @simonredfern The reason is this arg is set true: This arg is for increase compile speed: reference here |
… is permanently hidden by definition of object Xxxx
jenkins pass: jenkins job
there still have some warning as follow:
these warnings reason is some classes are deprecated, but we must still use them as follow:

and scala language have no solution for this problem, this is the discussion of this problem, unfortunately, at last this problem will not supply a solution.
This warnings no harm, we just keep them.
@simonredfern
please add a webhook to OBP-API:
after add this webhook, our OBP-API will automatic install to jitpack maven repository when develop branch have new commit.
other projects can dependent new jar in this way: