Skip to content

fix all compile warnings #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2019
Merged

Conversation

oldbig
Copy link
Contributor

@oldbig oldbig commented Jun 15, 2019

jenkins pass: jenkins job

there still have some warning as follow:

12:01:03 [WARNING] there were 15 deprecation warnings
12:01:03 [WARNING] there were two deprecation warnings (since 06/12/2017)
12:01:03 [WARNING] there was one deprecation warning (since 10-05-2019)
12:01:03 [WARNING] there were four deprecation warnings (since 2017-12-25)
12:01:03 [WARNING] there was one deprecation warning (since 2018-02-23)
12:01:03 [WARNING] there were 12 deprecation warnings (since 24 July 2017)
12:01:03 [WARNING] there were 35 deprecation warnings in total; re-run with -deprecation for details
12:01:03 [WARNING] there were 13 feature warnings; re-run with -feature for details
12:01:03 [WARNING] 8 warnings found

these warnings reason is some classes are deprecated, but we must still use them as follow:
Shuang-screen 2019-06-15 pm8 01 43

and scala language have no solution for this problem, this is the discussion of this problem, unfortunately, at last this problem will not supply a solution.
This warnings no harm, we just keep them.

@simonredfern
please add a webhook to OBP-API:

On GitGub go to repository Settings -> Webhooks & Services -> Add webhook.
Webhook URL: https://jitpack.io/api/webhooks
Content type: application/json

Shuang-screen 2019-06-15 pm8 23 32

Shuang-screen 2019-06-15 pm8 25 03

after add this webhook, our OBP-API will automatic install to jitpack maven repository when develop branch have new commit.
other projects can dependent new jar in this way:

    <repositories>
        <repository>
            <id>jitpack.io</id>
            <url>https://www.jitpack.io</url>
        </repository>
    </repositories>
    <dependencies>
        <dependency>
            <groupId>com.github.OpenBankProject.OBP-API</groupId>
            <artifactId>obp-commons</artifactId>
            <version>develop-SNAPSHOT</version>
        </dependency>
    </dependencies>

@@ -488,8 +488,6 @@ class Boot extends MdcLoggable {

Migration.database.executeScripts()

Glossary.glossaryItems
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line do nothing, will cause a warning.


trait ObpActorHelper {

def extractResult[T](in: T) = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally wrong use of generic and match case, cause warnings.

@@ -20,38 +21,20 @@ trait ObpActorInit extends MdcLoggable{
val TIMEOUT = (ACTOR_TIMEOUT seconds)
implicit val timeout = Timeout(ACTOR_TIMEOUT * (1000 milliseconds))

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally wrong use of generic and match case, and asInstanceOf.
so just remove it, and original caller switch to call extractFutureToBox method

@oldbig
Copy link
Contributor Author

oldbig commented Jun 16, 2019

Hi @simonredfern
There is one warning left not deal with yet:
Shuang-screen 2019-06-16 pm4 04 11

The reason is this arg is set true:
Shuang-screen 2019-06-16 pm4 05 14

This arg is for increase compile speed: reference here
maybe someone need this feature to have good compile speed, so I did not change it to "false", It is no harm to our project, what do you think this?

… is permanently hidden by definition of object Xxxx
@simonredfern simonredfern merged commit 141e364 into OpenBankProject:develop Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants