Skip to content

Added support for Mobile data sources/components #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2023

Conversation

rubinatorz
Copy link
Contributor

Hey @Cyb3rWard0g !

ATT&CK v13 is released this week, including Mobile data sources. I've added the mobile data sources and components to attackcti. Hope you have time to merge this soon 🤓

@Cyb3rWard0g
Copy link
Collaborator

Thank you very much @rubinatorz ! Sorry for the late response. Taking a look at it today :) I appreciate your contributions! I will update the library soon.

@rubinatorz
Copy link
Contributor Author

Thanks @Cyb3rWard0g

Today I've added a few more things: using enrich_techniques_data_sources within the get_mobile_techniques and get_ics_techniques (get_enterprise_techniques was already using this).

Within enrich_techniques_data_sources I removed the check on x_mitre_data_sources. This attribute is not used/updated anymore by MITRE. It not there for the new Mobile data sources for example. See mitre/cti#213.

For the enrichment in enrich_techniques_data_sources it still uses the x_mitre_data_sources attribute, also for Mobile to keep it like it is now. But maybe for the future, we need to think on what to do with x_mitre_data_sources as MITRE discontinued the use of this.

Copy link
Collaborator

@Cyb3rWard0g Cyb3rWard0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @rubinatorz ! Looks great! sorry for the delay. I got sidetracked with something at work and a conference.

@Cyb3rWard0g Cyb3rWard0g merged commit 3b7efa9 into OTRF:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants