This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: avoid duplicate modules from tns-core-modules and @nativescript/core #1103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AngularCompilerPlugin is resolving the files based on the
paths
property from the tsconfig and we have to unify the core modules package name in order to avoid duplicate modules causing app crashes on Android.PR Checklist
What is the current behavior?
vendor.js
contains both the@nativescrip/core/ui/application
and the proxytns-core-modules/ui/application
in Angular apps with short imports support in theirtsconfig
:What is the new behavior?
We are processing the
tsconfig
paths and unifying the core modules package name in order too keep a single package name in the generated code.Related to: may failing Angular related e2e tests