[Do Not Merge]fix(list-view): Recycle items for component children #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not recycling item views if the item contained a single custom component child.
vakrilov
suggested changes
Apr 5, 2017
| @@ -160,6 +162,7 @@ export class ListViewComponent implements DoCheck, OnDestroy, AfterContentInit { | |||
|
|
|||
| if (args.view && args.view[NG_VIEW]) { | |||
| listViewLog("onItemLoading: " + index + " - Reusing existing view"); | |||
| console.log("onItemLoading: " + index + " - Reusing existing view"); | |||
There was a problem hiding this comment.
Debug console.log leftover?
There was a problem hiding this comment.
This is the code that should extract the view ref, event if the root view was "wrapped" in Stack layout
| @@ -169,6 +172,7 @@ export class ListViewComponent implements DoCheck, OnDestroy, AfterContentInit { | |||
| } | |||
| } else { | |||
| listViewLog("onItemLoading: " + index + " - Creating view from template"); | |||
| console.log("onItemLoading: " + index + " - Creating view from template"); | |||
There was a problem hiding this comment.
Debug console.log leftover?
| @@ -242,7 +246,12 @@ export interface ComponentView { | |||
| export type RootLocator = (nodes: Array<any>, nestLevel: number) => View; | |||
|
|
|||
| export function getItemViewRoot(viewRef: ComponentView, rootLocator: RootLocator = getSingleViewRecursive): View { | |||
| const rootView = rootLocator(viewRef.rootNodes, 0); | |||
| let rootView = rootLocator(viewRef.rootNodes, -1); | |||
| if (rootView instanceof ProxyViewContainer) { | |||
There was a problem hiding this comment.
I think a more borad check should be used:
if (!args.view instanceof LayoutBase || args.view instanceof ProxyViewContainer)
This will handle cases when template produces a single Label or Button for example
vakrilov
changed the title
|
Closing in because of #743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not recycling item views if the item contained a single
custom component child.
Fixes #737