Send patches to state subscribers #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribers of the new BaseController will now also receive a patch for each state change, in addition to a copy of the new state. Patches can make it easier to efficiently serialize state updates. This was done as part of the controller redesign (#337).
Gudahtt
commented
Feb 23, 2021
| const nextState = produce(this.internalState, callback) as S; | ||
| this.internalState = nextState; | ||
| const [nextState, patches] = produceWithPatches(this.internalState, callback); | ||
| this.internalState = nextState as S; |
There was a problem hiding this comment.
It would be nice if this as S could be omitted, but when I leave it out I get an error I don't understand 🤔
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Subscribers of the new BaseController will now also receive a patch for each state change, in addition to a copy of the new state. Patches can make it easier to efficiently serialize state updates. This was done as part of the controller redesign (#337).
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Subscribers of the new BaseController will now also receive a patch for each state change, in addition to a copy of the new state. Patches can make it easier to efficiently serialize state updates. This was done as part of the controller redesign (#337).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscribers of the new BaseController will now also receive a patch for each state change, in addition to a copy of the new state. Patches can make it easier to efficiently serialize state updates.
This was done as part of the controller redesign (#337).