-
Notifications
You must be signed in to change notification settings - Fork 16
Keep track of map history in terms of pixels rather than latitude, longitude #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30bbbba
to
e96d009
Compare
I see that the reload feature has a test, perhaps @ben-lu-uw would be willing to add a test or two for history within / across zoom levels? Is there anything else we could test that would be in doubt, ever? |
Nothing else comes to mind at the moment but it would be great to have tests that explore history when it's outside the scope of a projection, to avoid reverting back to the initial issue in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No there shouldn't be any accepted level of distortion, I'll have a look at it. Update: This is more an issue with leaflet + projections, and not related to the history changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good to me, nice idea to test across zoom levels, naturally would work within single zoom level.
There are also tests inside the mapContextMenu.test.js file, in hind sight I should have suggested @ben-lu-uw add these tests to that file but it's not a major issue. |
Rather than keeping track of navigation history in terms of latitude and longitude, this uses tcrs and calculates offsets to navigate history. This also accounts for zoom.
Closes #542