Restore support for usernames containing '@' in connection strings. #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to version 0.18.0 it was possible to have an '@' in a connection string, but that feature got lost when the parsing code was rewritten to support multiple host addresses.
|
If I'm reading libpq's parsing code correctly, it looks for the first |
elprans
added a commit
that referenced
this pull request
Aug 19, 2019
When a connection string component contains characters that have a special meaning in the URI (e.g. '@' or '='), percent-encoding must be used. asyncpg must take care to unquote the parsed components correctly, and it doesn't currently. Additionally, this makes asyncpg follow the libpq's behavior of parsing the authentication part of netloc, i.e. split on the first '@' and not the last. Fixes: #418 Fixes: #471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to version 0.18.0 it was possible to have an '@' in a connection
string, but that feature got lost when the parsing code was rewritten to
support multiple host addresses.