Implement support for pool connection rotation #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
force-pushed
the
pool-rotation
branch
2 times, most recently
from
224e977 to
ddff26c
Compare
1st1
reviewed
Jun 4, 2018
asyncpg/pool.py
Outdated
| @@ -409,6 +402,73 @@ def __init__(self, *connect_args, | |||
| self._initialized = True | |||
| return self | |||
|
|
|||
| def set_connect_args(self, dsn=None, *, | |||
| connection_class=connection.Connection, **kwargs): | |||
There was a problem hiding this comment.
I wouldn't allow to change connection_class via set_connect_args, there's no clear use case for that.
1st1
reviewed
Jun 4, 2018
| '_working_addr', '_working_config', '_working_params', | ||
| '_holders', '_initialized', '_closing', '_closed', | ||
| '_connection_class') | ||
| '_connection_class', '_generation') | ||
|
|
||
| def __init__(self, *connect_args, |
There was a problem hiding this comment.
Could you please add a DeprecationWarning if len(connect_args) > 1?
1st1
approved these changes
Jun 4, 2018
The new `Pool.expire_connections()` method expires all currently open connections, so they would be replaced with fresh ones on the next `acquire()` attempt. The new `Pool.set_connect_args()` allows changing the connection arguments for an existing pool instance. Coupled with `expire_connections()`, it allows adapting the pool to the new environment conditions without having to replace the pool instance. Fixes: #291
|
Awesome, Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
Pool.cycle()method expires all currently open connections,so they would be replaced with fresh ones on the next
acquire()attempt.
The new
Pool.set_connect_args()allows changing the connectionarguments for an existing pool instance. Coupled with
cycle(), itallows adapting the pool to the new environment conditions without
having to replace the pool instance.
Fixes: #291