Add support for reading passwords from .pgpass #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
force-pushed
the
pgpass
branch
6 times, most recently
from
89dee7f to
57f200a
Compare
1st1
reviewed
Mar 5, 2018
| if r: | ||
| return None | ||
| else: | ||
| return pathlib.Path(buf.value) / 'postgresql' |
There was a problem hiding this comment.
Please add a comment explaining why using Path.home() would not be enough.
1st1
approved these changes
Mar 5, 2018
This largely mirrors libpq's behaviour with respect to ~/.pgpass. Fixes: #267.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This largely mirrors libpq's behaviour with respect to ~/.pgpass.
Fixes: #267.