Guard transaction methods against underlying connection release #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Dec 3, 2017
tests/test_pool.py
Outdated
| async with con.transaction(): | ||
| for record in await con.fetch("SELECT 1"): | ||
| yield record | ||
| '''), globals(), locals_) | ||
|
|
There was a problem hiding this comment.
Please put iterate = locals_['iterate']here for readability
1st1
approved these changes
Dec 3, 2017
Similarly to other connection-dependent objects, transaction methods should not be called once the underlying connection has been released to the pool. Also, add a special handling for the case of asynchronous generator finalization, in which case it's OK for `Transaction.__aexit__()` to be called _after_ `Pool.release()`, since we cannot control when the finalization task would execute. Fixes: #232.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to other connection-dependent objects, transaction methods
should not be called once the underlying connection has been released to
the pool.
Also, add a special handling for the case of asynchronous generator
finalization, in which case it's OK for
Transaction.__aexit__()to becalled after
Pool.release(), since we cannot control when thefinalization task would execute.
Fixes: #232.