*Experimental* support for kwargs. #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue #9 for details. This is not ready to be committed yet. My main concern is the prolification of 'kwargs' argument in all APIs. Perhaps a better approach would be implemnt a Plugin/Middleware class.
|
+1 to plugin/middleware capabilities. |
elprans
reviewed
Sep 18, 2017
| yield buf | ||
| i += 1 | ||
|
|
||
| # Build a query that has 33000 unique and shortest possible |
There was a problem hiding this comment.
Let's use 32767. 33000 looks like an arbitrary limit rather than INT16_MAX.
| for i, name in enumerate(count_base61()): | ||
| if i == 33000: # Max number of arguments Postgres can accept. | ||
| break | ||
| query += f'${name}+' |
|
Yes, looks fairly messy with |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #9 for details.
This is not ready to be committed yet. My main concern is the
prolification of 'kwargs' argument in all APIs. Perhaps a better
approach would be implemnt a Plugin/Middleware class.