-
Notifications
You must be signed in to change notification settings - Fork 419
incorrect PostgreSQL version, failed to connect to PG10/Debian #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Some distros (e.g Debian) like may inject their branding into the numeric version string, so make sure to only look at stuff before the first space. Fixes: #250.
Sigh, arguably it's a Debian bug. There's no good reason why they should adulterate the |
thanks for the quick fix. |
The version is reported by the server when the connection is established via a |
Some distros (e.g Debian) like may inject their branding into the numeric version string, so make sure to only look at stuff before the first space. Fixes: #250.
It seems like this problem is now present in new/upgrades PostgreSQL databases on Heroku, so anyone running asyncpg on Heroku with a recent PostgreSQL version now needs to run asyncpg from master. It would be lovely to have a new release cut which includes this workaround. |
MagicStack#250 MagicStack#261 MagicStack#771 Just tried to use this library through Ormar->Databases->AsyncPG against a Yugabyte cluster and hit issue 771. Looks like this has been a problem for a while now so going for a complete overhaul of the server version extraction method. Using a groupdict regex against the version string allows for much higher flexibility in extracting what we're looking for and fixes 771 while not breaking any of the existing version patterns.
#250 #261 #771 Just tried to use this library through Ormar->Databases->AsyncPG against a Yugabyte cluster and hit issue 771. Looks like this has been a problem for a while now so going for a complete overhaul of the server version extraction method. Using a groupdict regex against the version string allows for much higher flexibility in extracting what we're looking for and fixes #771 while not breaking any of the existing version patterns.
uvloop?: not related to event loop
I experience an issue when trying to connect to my local postgresql cluster. The error is :
PostgreSQL version given by the server itself :
PostgreSQL was installed from the main debian repositories :
I looked into the code but failed to find where the version is fetched from PG.
The
version_string
received in thesplit_server_version_string
function is equal to"10.1 (Debian 10.1-3)"
but it should be only"10.1"
according to the rest of the function.Any ideas to fix it ?
The text was updated successfully, but these errors were encountered: