Skip to content

fix: Detect leetcode file by the comments #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2019
Merged

fix: Detect leetcode file by the comments #417

merged 2 commits into from
Sep 14, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Sep 14, 2019

  1. To prevent Code Lens appearing unexpectedly when the user is not practicing.
  2. Since the setting leetcode.filePath allows user to customize the file name, use the file name to determine whether to show the Code Lens is not valid any more.

@jdneo jdneo added this to the 0.15.4 milestone Sep 14, 2019
@jdneo jdneo requested review from poppinlp and Vigilans September 14, 2019 06:44
@jdneo jdneo merged commit a6d34bc into master Sep 14, 2019
@jdneo jdneo deleted the cs/codelens branch September 14, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poppinlp poppinlp Awaiting requested review from poppinlp

@Vigilans Vigilans Awaiting requested review from Vigilans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.4
Development

Successfully merging this pull request may close these issues.
1 participant
@jdneo