Skip to content

Implement additional compiler flags as per KT-75078 #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

sandwwraith
Copy link
Member

Add forgotten explicitApi() to HOCON

Add forgotten explicitApi() to HOCON
@sandwwraith sandwwraith requested a review from shanshin March 5, 2025 17:47
@sandwwraith
Copy link
Member Author

cc @woainikk

@sandwwraith
Copy link
Member Author

I'm not sure I want to merge this tho — because of https://youtrack.jetbrains.com/issue/KT-75713 and https://youtrack.jetbrains.com/issue/KT-75712

@sandwwraith sandwwraith marked this pull request as ready for review March 6, 2025 11:10
@sandwwraith
Copy link
Member Author

-Wextra will be run only in separate KUP configuration.

@woainikk
Copy link
Contributor

woainikk commented Mar 6, 2025

-Wextra will be run only in separate KUP configuration.

no, it will be run on the same UP configuration

@@ -50,4 +50,3 @@ dependencies {
implementation(libs.gradlePlugin.animalsniffer)
implementation(libs.gradlePlugin.binaryCompatibilityValidator)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but this blank line was excessive anyway

@sandwwraith sandwwraith merged commit 27e352d into dev Mar 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants