Skip to content

improve robustness of Vararg checks in newly added abstract_eval_xxx #58325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented May 6, 2025

Otherwise these subroutines may raise unhandled Vararg errors when compiling e.g. CassetteOverlay for complex call graphs.

@aviatesk aviatesk force-pushed the avi/isva-robustness branch from e3597c3 to e48221f Compare May 6, 2025 03:30
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtjnash vtjnash added compiler:inference Type inference backport 1.12 Change should be backported to release-1.12 labels May 6, 2025
@aviatesk aviatesk force-pushed the avi/isva-robustness branch 2 times, most recently from 18b9384 to b45dc51 Compare May 6, 2025 03:41
Otherwise these subroutines may raise `unhandled Vararg` errors when
compiling e.g. CassetteOverlay for complex call graphs.
@aviatesk aviatesk force-pushed the avi/isva-robustness branch from b45dc51 to 19a2f6f Compare May 6, 2025 03:42
@aviatesk aviatesk merged commit c894e04 into master May 6, 2025
7 checks passed
@aviatesk aviatesk deleted the avi/isva-robustness branch May 6, 2025 07:43
aviatesk added a commit that referenced this pull request May 6, 2025
…xx` (#58325)

Otherwise these subroutines may raise `unhandled Vararg` errors when
compiling e.g. CassetteOverlay for complex call graphs.
@aviatesk aviatesk mentioned this pull request May 6, 2025
53 tasks
@aviatesk aviatesk removed the backport 1.12 Change should be backported to release-1.12 label May 6, 2025
serenity4 pushed a commit to serenity4/julia that referenced this pull request May 7, 2025
…xx` (JuliaLang#58325)

Otherwise these subroutines may raise `unhandled Vararg` errors when
compiling e.g. CassetteOverlay for complex call graphs.
charleskawczynski pushed a commit to charleskawczynski/julia that referenced this pull request May 12, 2025
…xx` (JuliaLang#58325)

Otherwise these subroutines may raise `unhandled Vararg` errors when
compiling e.g. CassetteOverlay for complex call graphs.
charleskawczynski pushed a commit to charleskawczynski/julia that referenced this pull request May 12, 2025
…xx` (JuliaLang#58325)

Otherwise these subroutines may raise `unhandled Vararg` errors when
compiling e.g. CassetteOverlay for complex call graphs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants