-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
juliac: Add rudimentary Windows support #57481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This was essentially working as-is, except for our reliance on a C compiler.
It feels a bit odd to have |
Let's make juliac depend on PackageCompiler so we don't have to copy code from there. |
Why not move the whole juliac code to PackageCompiler? |
Yeah we could do that; I think PackageCompiler.jl can be an app with juliac as its |
Whether you decide to install PackageCompiler.jl by default or not is a decision for you and the development team. Just would like to bring to your attention that julia installation size has increased with each version. I will stop there as I don't want to enter in an offtopic conversation and link some interesting discussions/comments done by members of the Julia community: |
It may be worthwhile thought to think about the terminology, since we have many more stages of compilation than most other language ecosystems, and we call all of them compiler (or maybe disambiguate the terms in our documentation):
|
GCC can be updated to v15 both in this PR and PackageCompiler. What is missing to merge this PR please? |
Can this be included in 1.12? EDIT: I See it is marked for backport to 1.12. But probably should be merged to master first, right? |
It seems to be marked for backport in 1.12 so I assume the answer is yes? Plus, if I am not mistaken, the functionality is marked as experimental so I guess it can be changed/removed at any time in the future... On windows I have manually installed a compiler (gcc) and successfully created an exe file and a shared library (not without a bit of pain), so this PR is not strictly needed but it makes life much easier... |
This was essentially working as-is, except for our reliance on a C compiler.
Not sure how we feel about having an
Artifacts.toml
floating around ourcontrib
folder, but I'm not aware of an alternative other than movingjuliac.jl
to a subdirectory.