Skip to content

fix: allowing skyline keywords as columns, tables, etc. #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

nicky6s
Copy link
Contributor

@nicky6s nicky6s commented Jan 5, 2025

Following on from this PR -> #2078

Associated to this issue -> #2136

The keywords LOW, HIGH, PLUS and INVERSE were missing from line 2048 of JSqlParserCC.jjt as they were added as new restricted keywords. I have added them manually to line 2048 and removed them as restricted keywords.

I could have done the same with PREFERRING, but since #2078 was merged its become an important new keyword like WHERE, so Ive left it out.

@manticore-projects
Copy link
Contributor

manticore-projects commented Jan 5, 2025

Greetings! Thank you for your contribution and good job overall.

However, the grammar has some ambiguities now:

         line 3461, column 11 and line 3464, column 11 respectively.
         A common prefix is: "HIGH" "NOT"
         Consider using a lookahead of 3 or more for earlier expansion.
Warning: Choice conflict involving two expansions at
         line 3462, column 11 and line 3464, column 11 respectively.
         A common prefix is: "LOW" "NOT"
         Consider using a lookahead of 3 or more for earlier expansion.
Warning: Choice conflict involving two expansions at
         line 3463, column 11 and line 3464, column 11 respectively.
         A common prefix is: "INVERSE" "("
         Consider using a lookahead of 3 or more for earlier expansion.

Please fix by inserting the advised LOOKAHEADS. Then I would merge.

@nicky6s nicky6s force-pushed the fix-update-with-low branch from 6e488c0 to 9eeb92f Compare January 6, 2025 20:05
@nicky6s
Copy link
Contributor Author

nicky6s commented Jan 6, 2025

@manticore-projects Thanks for reviewing

Please fix by inserting the advised LOOKAHEADS

Ive made this change -> 9eeb92f

@manticore-projects manticore-projects merged commit f9b1cbd into JSQLParser:master Jan 7, 2025
1 of 2 checks passed
@manticore-projects
Copy link
Contributor

Good job, thank you for your contribution!

@nicky6s nicky6s deleted the fix-update-with-low branch January 7, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants