Keywords2: Update whitelisted Keywords #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Keywords and document, which keywords are allowed for what purpose
Derive All Keywords from Grammar directly Generate production for Object Names (semi-) automatically Add parametrized Keyword Tests
Parallel Test execution Gradle Caching Explicitly request for latest JavaCC 7.0.10
Parallel Test execution Gradle Caching Explicitly request for latest JavaCC 7.0.10
# Conflicts: # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
Update keywords
# Conflicts: # build.gradle
# Conflicts: # build.gradle # ruleset.xml # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt # src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java # src/test/java/net/sf/jsqlparser/statement/select/SpecialOracleTest.java
# Conflicts: # README.md # build.gradle # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt # src/test/java/net/sf/jsqlparser/statement/select/SpecialOracleTest.java
Show the Statement's Java Objects in a tree hierarchy
Temporarily reduce the Coverage checks regarding Minimum Coverage and Maximum Missed Lines in order to get the Keywords PR accepted. We should do a major Code cleanup afterwards.
# Conflicts: # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
# Conflicts: # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
|
Since I have accepted those enhanced keywords, why is this pr so large? |
update/cleanup dependencies in Maven and Gradle add EXEC plugin to Maven for updating white listed keywords in the Grammaer
It actually changed only 4 Files:
mvn compile exec:java
I do not know, why GIT carries all the change set since branching, after I merged MASTER. |
Merged
wumpz
reviewed
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Keywords in
RelObjectNameWithoutValueafter PR #1649 introduced new tokens.Workflow should be like that:
gradle updateKeywordsmvn packageorgradle build(it does not matter)Using
gradle updateKeywordstask is optional, you can also add the new Tokens manually has it has always been done before.After accepting the Keywords PR, any further PR will automatically fail acceptance tests, unless keywords are in order.