Skip to content

update handling shape and axes of scipy interface #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 9, 2025

In this PR,

  1. SciPy interface is updated to use the same function from SciPy for handling shape and axes in N-D FFTs (Currently it uses _cook_nd_args function which is from NumPy, in this PR, this function is replaced with _init_nd_shape_and_axes which is from SciPy)

  2. Although SciPy has overwrite_x parameter for real-to-complex and complex-to-real FFTs, it has not been used internally. It has not been used in mkl_fft as well and it is not a limitation for mkl_fft so docstring is updated accordingly.

@vtavana vtavana self-assigned this May 9, 2025
@vtavana vtavana marked this pull request as ready for review May 9, 2025 14:21
@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 14:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SciPy interface to use SciPy’s native helper (_init_nd_shape_and_axes) for handling shape and axes in N-D FFTs instead of NumPy’s _cook_nd_args, and clarifies the treatment of the overwrite_x parameter in docstrings. Additionally, minor modifications are made to the CHANGELOG and conda workflow to ensure consistency with dependency requirements.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
mkl_fft/interfaces/_scipy_fft.py Updated FFT function implementations to call _init_nd_shape_and_axes and removed redundant checks on overwrite_x; minor docstring adjustments applied.
CHANGELOG.md Updated changelog notes to reflect the new behavior in the SciPy interface and aligned numpy interface wording.
.github/workflows/conda-package.yml Adjusted commands for conda environment creation and package installation for better dependency handling.
Files not reviewed (1)
  • mkl_fft/_pydfti.pyx: Language not supported
Comments suppressed due to low confidence (1)

mkl_fft/interfaces/_scipy_fft.py:428

  • [nitpick] The parameter 'overwrite_x' remains in the function signature but is not used. Consider updating the function docstring or parameter description to clarify that it is maintained for API compatibility and is ignored in the current implementation.
# Note: overwrite_x is not utilized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant