Skip to content

Remove code duplication. #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Remove code duplication. #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 8 additions & 124 deletions dpctl-capi/tests/test_sycl_device_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,20 @@ using namespace cl::sycl;
struct TestDPCTLSyclDeviceInterface
: public ::testing::TestWithParam<const char *>
{
DPCTLSyclDeviceSelectorRef DSRef = nullptr;
DPCTLSyclDeviceRef DRef = nullptr;

TestDPCTLSyclDeviceInterface()
{
EXPECT_NO_FATAL_FAILURE(DSRef = DPCTLFilterSelector_Create(GetParam()));
auto DS = DPCTLFilterSelector_Create(GetParam());
if (DS) {
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DS));
}
DPCTLDeviceSelector_Delete(DS);
}

void SetUp()
{
if (!DSRef) {
if (!DRef) {
auto message = "Skipping as no device of type " +
std::string(GetParam()) + ".";
GTEST_SKIP_(message.c_str());
Expand All @@ -55,30 +59,21 @@ struct TestDPCTLSyclDeviceInterface

~TestDPCTLSyclDeviceInterface()
{
EXPECT_NO_FATAL_FAILURE(DPCTLDeviceSelector_Delete(DSRef));
DPCTLDevice_Delete(DRef);
}
};

TEST_P(TestDPCTLSyclDeviceInterface, Chk_Copy)
{
DPCTLSyclDeviceRef DRef = nullptr;
DPCTLSyclDeviceRef Copied_DRef = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(Copied_DRef = DPCTLDevice_Copy(DRef));
EXPECT_TRUE(bool(Copied_DRef));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(Copied_DRef));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetBackend)
{
DPCTLSyclDeviceRef DRef = nullptr;
DPCTLSyclBackendType BTy = DPCTLSyclBackendType::DPCTL_UNKNOWN_BACKEND;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(BTy = DPCTLDevice_GetBackend(DRef));
EXPECT_TRUE([BTy] {
switch (BTy) {
Expand All @@ -94,270 +89,165 @@ TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetBackend)
return false;
}
}());
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetDeviceType)
{
DPCTLSyclDeviceRef DRef = nullptr;
DPCTLSyclDeviceType DTy = DPCTLSyclDeviceType::DPCTL_UNKNOWN_DEVICE;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(DTy = DPCTLDevice_GetDeviceType(DRef));
EXPECT_TRUE(DTy != DPCTLSyclDeviceType::DPCTL_UNKNOWN_DEVICE);
EXPECT_TRUE(DTy != DPCTLSyclDeviceType::DPCTL_ALL);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetDriverInfo)
{
DPCTLSyclDeviceRef DRef = nullptr;
const char *DriverInfo = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(DriverInfo = DPCTLDevice_GetDriverInfo(DRef));
EXPECT_TRUE(DriverInfo != nullptr);
EXPECT_NO_FATAL_FAILURE(DPCTLCString_Delete(DriverInfo));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetName)
{
DPCTLSyclDeviceRef DRef = nullptr;
const char *Name = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(Name = DPCTLDevice_GetName(DRef));
EXPECT_TRUE(Name != nullptr);
EXPECT_NO_FATAL_FAILURE(DPCTLCString_Delete(Name));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetVendorName)
{
DPCTLSyclDeviceRef DRef = nullptr;
const char *VendorName = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(VendorName = DPCTLDevice_GetVendorName(DRef));
EXPECT_TRUE(VendorName != nullptr);
EXPECT_NO_FATAL_FAILURE(DPCTLCString_Delete(VendorName));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetMaxComputeUnits)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t n = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(n = DPCTLDevice_GetMaxComputeUnits(DRef));
EXPECT_TRUE(n > 0);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetMaxWorkItemDims)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t n = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(n = DPCTLDevice_GetMaxWorkItemDims(DRef));
EXPECT_TRUE(n > 0);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetMaxWorkItemSizes)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t *sizes = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(sizes = DPCTLDevice_GetMaxWorkItemSizes(DRef));
EXPECT_TRUE(sizes != nullptr);
EXPECT_NO_FATAL_FAILURE(DPCTLSize_t_Array_Delete(sizes));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetMaxWorkGroupSize)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t n = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(n = DPCTLDevice_GetMaxWorkGroupSize(DRef));
if (DPCTLDevice_IsAccelerator(DRef))
EXPECT_TRUE(n >= 0);
else
EXPECT_TRUE(n > 0);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetMaxNumSubGroups)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t n = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(n = DPCTLDevice_GetMaxNumSubGroups(DRef));
if (DPCTLDevice_IsAccelerator(DRef))
EXPECT_TRUE(n >= 0);
else
EXPECT_TRUE(n > 0);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPlatform)
{
DPCTLSyclDeviceRef DRef = nullptr;
DPCTLSyclPlatformRef PRef = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(PRef = DPCTLDevice_GetPlatform(DRef));
ASSERT_TRUE(PRef);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
EXPECT_NO_FATAL_FAILURE(DPCTLPlatform_Delete(PRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_IsAccelerator)
{
DPCTLSyclDeviceRef DRef = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_IsAccelerator(DRef));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_IsCPU)
{
DPCTLSyclDeviceRef DRef = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_IsCPU(DRef));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_IsGPU)
{
DPCTLSyclDeviceRef DRef = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_IsGPU(DRef));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_IsHost)
{
DPCTLSyclDeviceRef DRef = nullptr;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_IsHost(DRef));
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetSubGroupIndependentForwardProgress)
{
DPCTLSyclDeviceRef DRef = nullptr;
bool sub_group_progress = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(
sub_group_progress =
DPCTLDevice_GetSubGroupIndependentForwardProgress(DRef));
auto D = reinterpret_cast<device *>(DRef);
auto get_sub_group_progress =
D->get_info<info::device::sub_group_independent_forward_progress>();
EXPECT_TRUE(get_sub_group_progress == sub_group_progress);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPreferredVectorWidthChar)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t vector_width_char = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(vector_width_char =
DPCTLDevice_GetPreferredVectorWidthChar(DRef));
EXPECT_TRUE(vector_width_char != 0);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPreferredVectorWidthShort)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t vector_width_short = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(vector_width_short =
DPCTLDevice_GetPreferredVectorWidthShort(DRef));
EXPECT_TRUE(vector_width_short != 0);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPreferredVectorWidthInt)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t vector_width_int = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(vector_width_int =
DPCTLDevice_GetPreferredVectorWidthInt(DRef));
EXPECT_TRUE(vector_width_int != 0);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPreferredVectorWidthLong)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t vector_width_long = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(vector_width_long =
DPCTLDevice_GetPreferredVectorWidthLong(DRef));
EXPECT_TRUE(vector_width_long != 0);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPreferredVectorWidthFloat)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t vector_width_float = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(vector_width_float =
DPCTLDevice_GetPreferredVectorWidthFloat(DRef));
EXPECT_TRUE(vector_width_float != 0);
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPreferredVectorWidthDouble)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t vector_width_double = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(
vector_width_double = DPCTLDevice_GetPreferredVectorWidthDouble(DRef));
if (DPCTLDevice_HasAspect(DRef, DPCTL_SyclAspectToDPCTLAspectType(
Expand All @@ -368,16 +258,11 @@ TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPreferredVectorWidthDouble)
else {
EXPECT_TRUE(vector_width_double == 0);
}
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPreferredVectorWidthHalf)
{
DPCTLSyclDeviceRef DRef = nullptr;
size_t vector_width_half = 0;
EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
if (!DRef)
GTEST_SKIP_("Device not found");
EXPECT_NO_FATAL_FAILURE(vector_width_half =
DPCTLDevice_GetPreferredVectorWidthHalf(DRef));
if (DPCTLDevice_HasAspect(DRef, DPCTL_SyclAspectToDPCTLAspectType(
Expand All @@ -388,7 +273,6 @@ TEST_P(TestDPCTLSyclDeviceInterface, Chk_GetPreferredVectorWidthHalf)
else {
EXPECT_TRUE(vector_width_half == 0);
}
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
}

INSTANTIATE_TEST_SUITE_P(DPCTLDevice_Fns,
Expand Down