Skip to content

Add support for Aspects #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 9, 2021
Merged

Add support for Aspects #307

merged 12 commits into from
Mar 9, 2021

Conversation

1e-to
Copy link
Contributor

@1e-to 1e-to commented Mar 2, 2021

Closes #292

@1e-to
Copy link
Contributor Author

1e-to commented Mar 3, 2021

@diptorupd , @oleksandr-pavlyk , I fixed all comments.

@diptorupd
Copy link
Contributor

@1e-to Thanks for the changes. Starting to look good. Couple of additional things that I thought of that we need to do:

  1. Add utility functions to translate aspects to strings and strings to aspects, like we have for device type.
  2. Change the aspect test case slightly. (refer my comments on the new test_dpctl_sycl_Device_aspects.cpp)

@1e-to
Copy link
Contributor Author

1e-to commented Mar 4, 2021

@diptorupd, all notes fixed.

diptorupd
diptorupd reviewed Mar 5, 2021
View reviewed changes
@diptorupd
Copy link
Contributor

Last few cosmetic changes and we should be good to go. @oleksandr-pavlyk can you review it once too.

@1e-to
Copy link
Contributor Author

1e-to commented Mar 5, 2021

@diptorupd, I fixed everything, but now cpp tests fail if aspect has not been implemented yet.
I am trying to solve this problem.

diptorupd
diptorupd previously approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after the last highly cosmetic change is finished.

diptorupd
diptorupd reviewed Mar 5, 2021
View reviewed changes
@diptorupd diptorupd self-requested a review March 9, 2021 17:36
@diptorupd diptorupd merged commit 5db1d6f into IntelPython:master Mar 9, 2021
diptorupd pushed a commit to diptorupd/dpctl that referenced this pull request Mar 13, 2021
@1e-to
Add support for Aspects (IntelPython#307)
5320a22 
* Add support of Current DPCPP aspects to dpctl.
* All aspects are now available in the C API using the `DPCTLDevice_HasAspect` function.
* Previous C API functions to get atomics aspects are now removed.
* Add utilities functions to convert SYCL aspects to dpctl aspect types and vice-versa
* Add a utility function to convert aspects to string.

Co-authored-by: etotmeni <[email protected]>
diptorupd pushed a commit that referenced this pull request Mar 13, 2021
@1e-to
Add support for Aspects (#307)
737ea70 
* Add support of Current DPCPP aspects to dpctl.
* All aspects are now available in the C API using the `DPCTLDevice_HasAspect` function.
* Previous C API functions to get atomics aspects are now removed.
* Add utilities functions to convert SYCL aspects to dpctl aspect types and vice-versa
* Add a utility function to convert aspects to string.

Co-authored-by: etotmeni <[email protected]>
diptorupd pushed a commit that referenced this pull request Apr 2, 2021
@1e-to
Add support for Aspects (#307)
7866742 
* Add support of Current DPCPP aspects to dpctl.
* All aspects are now available in the C API using the `DPCTLDevice_HasAspect` function.
* Previous C API functions to get atomics aspects are now removed.
* Add utilities functions to convert SYCL aspects to dpctl aspect types and vice-versa
* Add a utility function to convert aspects to string.

Co-authored-by: etotmeni <[email protected]>
@1e-to 1e-to deleted the aspects branch November 3, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk left review comments

@diptorupd diptorupd diptorupd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for aspects
3 participants
@1e-to @diptorupd @oleksandr-pavlyk