-
Notifications
You must be signed in to change notification settings - Fork 29
Fix for incorrect result in reduction over axis=0 #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The kernel is applicable if both inputs are F-contiguous, or if the first input if F-contiguous and we are reducing to 1d C-contiguous array. Closes gh-1391
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1392/index.html |
For me, building this branch gives a compiler warning
|
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_49 ran successfully. |
c1c6b0d
to
8d8ef0b
Compare
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_51 ran successfully. |
Thank you @ndgrigorian . I have added the parenthesis and the warning is gone for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dpnp tests are passing now. Thank you @oleksandr-pavlyk !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiler warning is gone and it resolves the issue
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Closes gh-1391
The specialized reduce_over_axis0 kernel should be called if both src/dst are F-contiguous, or when src is F-contig, and dst is C-contig but 1D (usually it is also F-contig in this case though).