Turn comparison call into assertion in test_usm_ndarray_ctor::test_flags #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the assertion about comparison with generic types before other assertions. This change is made in reference to Coverity scan issue.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1371/index.html |
|
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_20 ran successfully. |
|
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_20 ran successfully. |
ndgrigorian
approved these changes
Aug 27, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_20 ran successfully. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the assertion about comparison with generic types before other assertions in
test_flagstestThis change is made in reference to Coverity scan issue, which is a false positive, but the test can be improved anyway.