Skip to content

Add python 3.11 support #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jul 14, 2023

  • Have you provided a meaningful PR description?
    Add package build for python 3.11
  • Have you added a test, reproducer or referred to an issue with a reproducer?
    I've been able to successfully build it for numba-dpex Docker. All tests pass
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Copy link
Contributor

@ZzEeKkAa Please allow me to commit to your repo to this branch, or let's close this PR and reopen a new one with changes from this PR added to a branch in dpctl.

The change allows icpx to find these libraries in $BUILD_PREFIX
@oleksandr-pavlyk
Copy link
Contributor

@ZzEeKkAa Please allow me to commit to your repo to this branch, or let's close this PR and reopen a new one with changes from this PR added to a branch in dpctl.

Turns out I had permissions already, and have pushed the fix to unblock the build.

The hurdle was that there is NumPy available from intel channel, so NumPy from other channel was being installed. The NumPy from intel channel has dependency on intel-cmplr-lib-rt package which provides various libraries such as SVML, etc.

In the absence of these libraries from the $PREFIX the compiler was not able to link the sycl feature detection executable and the cmake configuration would fail, because libsycl.so requires SVML and other libraries.

The change I pushed extended LD_LIBRARY_PATH with $BUILD_PREFIX/lib to help the compiler in conda environment.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 83.218% (-0.02%) from 83.233% when pulling f3d9276 on ZzEeKkAa:feature/add_python_3_11 into f032154 on IntelPython:master.

@oleksandr-pavlyk
Copy link
Contributor

Both failures are due to use of fork instead of the branch. This is good to go in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants