Skip to content

Remove deprecated DPCTLDevice_GetMaxWorkItemSizes #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oleksandr-pavlyk opened this issue Aug 21, 2023 · 0 comments · Fixed by #1359
Closed

Remove deprecated DPCTLDevice_GetMaxWorkItemSizes #1358

oleksandr-pavlyk opened this issue Aug 21, 2023 · 0 comments · Fixed by #1359
Assignees
@oleksandr-pavlyk

Comments

@oleksandr-pavlyk
Copy link
Contributor

Excerpt from coverage build log:

[6/21] Building CXX object libsyclinterface/tests/CMakeFiles/dpctl_c_api_tests.dir/test_sycl_device_interface.cpp.o
/home/runner/work/dpctl/dpctl/libsyclinterface/tests/test_sycl_device_interface.cpp:181:37: warning: 'DPCTLDevice_GetMaxWorkItemSizes' is deprecated: Use DPCTLDevice_WorkItemSizes3d instead [-Wdeprecated-declarations]
    EXPECT_NO_FATAL_FAILURE(sizes = DPCTLDevice_GetMaxWorkItemSizes(DRef));
                                    ^
/home/runner/work/dpctl/dpctl/libsyclinterface/tests/../include/dpctl_sycl_device_interface.h:244:3: note: 'DPCTLDevice_GetMaxWorkItemSizes' has been explicitly marked deprecated here
[[deprecated("Use DPCTLDevice_WorkItemSizes3d instead")]]
  ^

This has been deprecated since oneAPI 2023.0.0 release.
@oleksandr-pavlyk oleksandr-pavlyk self-assigned this Aug 21, 2023
oleksandr-pavlyk added a commit that referenced this issue Aug 21, 2023
@oleksandr-pavlyk
Closes gh-1358
526e595 
Removes deprecated DPCTLDevice_GetMaxWorkItemSizes.

Added Null_DRef tests for DPCTLDevice_GetMaxWorkItemSizes1d,
DPCTLDevice_GetMaxWorkItemSizes2d,
DPCTLDevice_GetMaxWorkItemSizes3d
@oleksandr-pavlyk oleksandr-pavlyk mentioned this issue Aug 21, 2023
Merged
6 tasks
oleksandr-pavlyk added a commit that referenced this issue Aug 21, 2023
@oleksandr-pavlyk
Closes gh-1358
bcefda7 
Removes deprecated DPCTLDevice_GetMaxWorkItemSizes.

Added Null_DRef tests for DPCTLDevice_GetMaxWorkItemSizes1d,
DPCTLDevice_GetMaxWorkItemSizes2d, DPCTLDevice_GetMaxWorkItemSizes3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleksandr-pavlyk oleksandr-pavlyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes deprecated DPCTLDevice_GetMaxWorkItemSizes IntelPython/dpctl
1 participant
@oleksandr-pavlyk